Skip to content

Rizan_ibrahim-w1-react #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rizan-ibrahim
Copy link

@rizan-ibrahim rizan-ibrahim commented Jun 17, 2025

https://68518f005bf6d822c9ae0f1c--jocular-sprinkles-08926c.netlify.app/

  • A product list that displays all of the products in the all-products file. Note: the site is responsive, so have a look at the breakpoints in the deployed example project.
  • A category list that displays all of the categories in the all-categories file at the top of the page
  • If the user clicks on a category only the products that have that category in their category property should be displayed on the screen. Note: The categories listed in the product objects do not match up exactly with the categories in the categories list. You will have to find a solution to this without editing the files
  • There should only be 1 category active at a time and the user should see which category is selected.
  • You need to deploy your app somewhere (using something like netlify) and put the link in your PR!

Copy link

@ChingHsun ChingHsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is clean and well-organized. I also like the feature where selecting the same category again clears the filter. However, I noticed the product names are not displaying. Please fix this issue before approval.

Comment on lines 44 to 49
<div key={product.id} className="product">
<img src={product.image} alt={product.name} />
<h3>{product.name}</h3>
<p>{product.description}</p>
<p>${product.price}</p>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Th product name didn't show up
Screenshot 2025-06-29 at 05 14 29

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking, I fixed it now..

@ChingHsun ChingHsun self-assigned this Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants