Feras-w2-React #18
Open
Feras-w2-React #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkitson
requested changes
May 2, 2025
There was a problem hiding this comment.
Hey @Feras-ALdemashki this is working great! Just a couple of comments for me to address here - I'm not sure where you read that the home page route should be '/products/categories' so please correct me if I'm wrong!
| <Routes> | ||
| // in the assignment it says that the path for the all products or | ||
| categories should be "/products/categories" so when first opening the | ||
| app it will return 404 page not found. hope i understood this right. |
There was a problem hiding this comment.
I think this should effectively be the home page, so instead of routing to 'products/categories' should just route to '/'.
| @@ -0,0 +1,22 @@ | |||
| import { BrowserRouter, Route, Router, Routes } from "react-router-dom"; | |||
There was a problem hiding this comment.
You can remove 'Router' from the import here as its isn't being used
There was a problem hiding this comment.
Could you add the product title in here somewhere, as an h1 element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.