Skip to content

Error simplification #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Error simplification #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions FreeUI/scripts/errors.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,32 @@ firstErrorFrame.text:SetPoint("TOP", UIParent, 0, -76)
secondErrorFrame.text = F.CreateFS(secondErrorFrame)
secondErrorFrame.text:SetPoint("TOP", UIParent, 0, -85)

-- Translate from Error Number to a user-friendly string.
local function TranslateError(err)

-- By no means a full list, but covers most common ones and some Fury specific ones.
if err == 55 then return "That is not ready yet." end
if err == 149 then return "" end -- Isn't a blizzard error, not shown. Probably (You cannot do that while mounted)
if err == 193 then return "There is nothing to attack." end
if err == 220 then return "You need a target." end
if err == 250 then return "You need a 2H Weapon in your Offhand." end
if err == 359 then return "That is too far away." end

return "Unknown error: " .. err
end

local state = 0
firstErrorFrame:SetScript("OnHide", function() state = 0 end)
local Error = CreateFrame("Frame")
Error:RegisterEvent("UI_ERROR_MESSAGE")
Error:SetScript("OnEvent", function(_, _, error)
if state == 0 then
firstErrorFrame.text:SetText(error)
firstErrorFrame.text:SetText(TranslateError(error))
FadingFrame_Show(firstErrorFrame)
state = 1
else
secondErrorFrame.text:SetText(error)
secondErrorFrame.text:SetText(TranslateError(error))
FadingFrame_Show(secondErrorFrame)
state = 0
end
end)
end)