Skip to content

Conversation

ClaraUktar
Copy link

No description provided.

@ClaraUktar ClaraUktar self-assigned this Feb 1, 2022
@ClaraUktar ClaraUktar added the feature New feature or request label Feb 1, 2022
@TimRiedel
Copy link
Contributor

TimRiedel commented May 10, 2023

Hi @jonaskordt, @ClaraUktar. We would like to resume the work on the review process that is implemented specifically for the WHO. There are already plenty of useful features for the WHO, that we might reuse for a "new" review process when coming from the Visian menu / backend. That's why our idea is to refactor the code that Clara made in order to utilize common components and features in "both" review processes.
Although we did not do a deep dive into the WHO code yet, we think about a solution with multiple strategies that limit the common functionality depending on where the user is coming from and which role he/she has.

First of all, do you think this is feasible?

Secondly, how should we deal with all the existing PRs for the WHO annotation process? I can see that this PR is from the same branch as #337. There exists also an updateAPI branch, which also targets develop, but is not included in the other branch.
If we want to use the functionality implemented here, should this PR and #337 be merged into develop before we start working on the integration with the Visian Backend or should we create a new branch into which we merge this branch and our develop-annotation-service branch?

And another question, do you have a mock for the WHO API or an account with their system in order to test the proper communication between their service and Visian? This is also important in order to solve #416.

Thanks a lot for your help!

@jonaskordt
Copy link
Contributor

@TimRiedel I sadly don't have the answers to your questions here. @ClaraUktar is really the one who was working with the WHO. I'm sure we had some kind of test account, but I don't know the details. Refactoring and reusing the code that Clara wrote is probably a good idea. I think the best thing to do is to have a call or meeting with Clara.

@TimRiedel TimRiedel added the paused This is on hold for now label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request paused This is on hold for now

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants