feat: add env for write_jar_script again

[daeho-ro]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

I think I missed line break from

• feat: allow env for write_jar_script #19946

[daeho-ro]

I believe this cause some error on

• tika 3.2.0 homebrew-core#224764

[MikeMcQuaid]

These won't be exported if on the line before.

[daeho-ro]

Tried same as before, add export and line break.

[MikeMcQuaid]

I believe this cause some error on

• tika 3.2.0 homebrew-core#224764

It looks like JAVA_HOME isn't ending up set there for some reason.

[daeho-ro]

Here is the tika script

#!/bin/bash
JAVA_HOME="${JAVA_HOME:-/opt/homebrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home}" exec "${JAVA_HOME}/bin/java"  -jar "/opt/homebrew/Cellar/tika/3.2.0/libexec/tika-app-3.2.0.jar" "$@"

---

JAVA_HOME should be evaluated but it does not, right? How can I?

[MikeMcQuaid]

It maybe needs a preceding env. Let's revert for now.

[MikeMcQuaid]

#20011

[calvinit]

Here is the tika script

#!/bin/bash
JAVA_HOME="${JAVA_HOME:-/opt/homebrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home}" exec "${JAVA_HOME}/bin/java"  -jar "/opt/homebrew/Cellar/tika/3.2.0/libexec/tika-app-3.2.0.jar" "$@"

JAVA_HOME should be evaluated but it does not, right? How can I?

Maybe this can solve the problem?

def write_jar_script(target_jar, script_name, java_opts = "", java_version: nil, env: {})
  env[:JAVA_HOME] ||= Language::Java.overridable_java_home_env(java_version)[:JAVA_HOME]

  env_export = env.map do |key, value|
    %(export #{key}="#{value.gsub('"', '\"')}")
  end.join("\n")

  mkpath
  (self/script_name).write <<~EOS
    #!/bin/bash
    #{env_export}
    exec "${JAVA_HOME}/bin/java" #{java_opts} -jar "#{target_jar}" "$@"
  EOS
end

[MikeMcQuaid]

I think either:

env ENV=var exec

or

export ENV=var
exec

are needed here for valid syntax.

Either way, please ensure you've tested this and found it to be working locally before marking this as non-draft