Skip to content

Conversation

svetterIO
Copy link
Contributor

+1 Function: Compare LTPA files for idempotency on junction creation
+1 Feature: add local_ip as possible junction parameter

  • 1 typo in comment of entry.py

+1 Function: Compare LTPA files for idempotency on junction creation
+1 Feature: add local_ip as possible junction parameter
+ 1 typo in comment of entry.py
@svetterIO svetterIO mentioned this pull request Aug 15, 2019
@ram-ibm
Copy link
Collaborator

ram-ibm commented Oct 1, 2019

Please plan to use "ignore_password_for_idempotency" for skipping idempotency check for passwords that we cannot compare. I'll update code for ltpa_keyfile_password.

local_ip is not documented in the KnowldgeCenter. Which version is that introduced from so we can add version checks please?

@svetterIO
Copy link
Contributor Author

Is this new parameter "ignore_password_for_idempotency" planed for all other classes as well or only for this junctions.py ? Because I used the same logic also in pull request https://github.com/IBM-Security/ibmsecurity/pull/177/commits for server connections ibmsecurity/isam/aac/server_connections in ci.py, jdbc.py, smtp.py, ws.py.

The local_ip parameter seems to be existing since isam 7.0 (https://www.ibm.com/support/knowledgecenter/de/SSPREK_7.0.0.1/com.ibm.isam.doc_80/ameb_webseal_appl_guide/task/tsk_junction_parameter_rtv.html). So version checking shouldn't be necessary.
I also checked v9.0.1 and local_ip is present:
image

…force

Using ignore_password_for_idempotency  on set function for junction creation/modification instead of force parameter.

Same logic as already used for module_chains: (https://github.com/IBM-Security/ibmsecurity/blob/master/ibmsecurity/isam/fed/sts/module_chains.py)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants