Skip to content

Check transform exists before deleting #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check transform exists before deleting #318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae48e5e
Update http_transformation.py
zone-zero Jun 15, 2021
b5396cb
update http_transformation.py
Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ibmsecurity/isam/web/http_transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ def delete(isamAppliance, id, check_mode=False, force=False):
"""
Deleting a HTTP Transformation
"""
#check if transformation exists before deleting
# use get_all and search result because get errors with 404 if transform doesn't exist
ret_obj_content = get_all(isamAppliance)
if not next((item for item in ret_obj_content['data'] if item["id"] == id), None):
return isamAppliance.create_return_object(changed=False)

if force is True or _check(isamAppliance, id) is True:
if check_mode is True:
return isamAppliance.create_return_object(changed=True)
Expand Down