modify release-build for linux and macosx #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
…flag to save disk space Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Carmona Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: Pablo Gonzalez <[email protected]> Signed-off-by: PabloCarmona <[email protected]>
PabloCarmona
force-pushed
the
cicd-linux-macosx
branch
from
267f0e1 to
beb9cd0
Compare
Signed-off-by: PabloCarmona <[email protected]>
Signed-off-by: PabloCarmona <[email protected]>
|
The 1.0 version seem to work with #730 |
Thanks for your review @maljoras, yeah the 1.0 version is working with the suggestion you add in a discussion. Also in some archs user should change the Pytorch version that comes with the installation to the 2.3.1, something we are trying to solve in next minor patch for Pypi releases. I will add that to the discussion you opened or create a new one and think in the meantime in an update for the README or docs to clarify that. Thanks! |
Fryguy
reviewed
Jul 9, 2025
Comment on lines
+51
to
+53
| curl -fsSL https://clis.cloud.ibm.com/install/linux | sh | ||
| ibmcloud plugin install cos | ||
| ibmcloud login --apikey "$IBM_CLOUD_API_KEY" -r "$IBM_CLOUD_REGION" -g "$IBM_CLOUD_RESOURCE_GROUP" |
There was a problem hiding this comment.
Not necessarily for this PR, but we have an official github action for setting up the CLI, logging in and installing plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Description
Details