Skip to content

Add localization service #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Add localization service #450

wants to merge 26 commits into from

Conversation

d-gregorczyk
Copy link
Collaborator

@d-gregorczyk d-gregorczyk commented Jun 16, 2025 •
edited by JavierEspina
Loading

☑ Mandatory Tasks

The following aspects have been respected by the pull request assignee and at least one reviewer:

  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer

@d-gregorczyk
feat: #40 add localization service tf2 outline, general transaction d…
f4ded9d 
…escription and sequence diagram.
@d-gregorczyk
fix: #40 actor roles table of dev-33.
d3ad051
@d-gregorczyk
fix: #40 plantuml sequence diagram of dev-33.
1846413
@d-gregorczyk
fix: #40 plantuml sequence diagram of dev-33 (remove SDC tag).
bd8c149
@d-gregorczyk
fix: #40 reference to get localized text response assembling requirem…
e9db42b 
…ent (r0504 -> r0503).
@d-gregorczyk
fix: #40 various spelling and naming mistakes.
23a95a9
@d-gregorczyk
feat: #40 add mdpws message description.
c8b7fe5
@d-gregorczyk
fix: #40 include dev-33 mdpws message description.
aad3efb
@d-gregorczyk
chore: #40 remove blank lines.
4dafb57
@d-gregorczyk
fix: #40 rephrase "good practice" sentence to request localized texts.
23e45a8
@d-gregorczyk
feat: add conditional requirement to ask for the presence of a locali…
36d5071 
…zation service.
@d-gregorczyk
feat: #40 add localization service tf2 outline, general transaction d…
02a6b3e 
…escription and sequence diagram.
@d-gregorczyk
fix: #40 actor roles table of dev-33.
55bc43b
@d-gregorczyk
fix: #40 plantuml sequence diagram of dev-33.
812827d
@d-gregorczyk
fix: #40 plantuml sequence diagram of dev-33 (remove SDC tag).
17cd8b8
@d-gregorczyk
fix: #40 reference to get localized text response assembling requirem…
d167980 
…ent (r0504 -> r0503).
@d-gregorczyk
fix: #40 various spelling and naming mistakes.
3319f91
@d-gregorczyk
feat: #40 add mdpws message description.
6d982a1
@d-gregorczyk
fix: #40 include dev-33 mdpws message description.
5df7f25
@d-gregorczyk
chore: #40 remove blank lines.
67ca3ce
@d-gregorczyk
fix: #40 rephrase "good practice" sentence to request localized texts.
af44678
@d-gregorczyk
feat: add conditional requirement to ask for the presence of a locali…
35f5cb1 
…zation service.
@d-gregorczyk
docs: add changelog item for #40.
bc1f005
@d-gregorczyk
Merge remote-tracking branch 'origin/40-append-dev-33-internationaliz…
00e5122 
…ation-localization-service' into 40-append-dev-33-internationalization-localization-service
@d-gregorczyk d-gregorczyk mentioned this pull request Jun 16, 2025
Closed
2 tasks
JavierEspina
JavierEspina requested changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@JavierEspina JavierEspina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • See my 4 inline comments with questions / change requests.
  • In addition, the new transaction is not listed in the Vol1 SDPi-P table. I have just made a commit with that change.
  • Otherwise looks good!

@JavierEspina
Update tf1-ch-10-sdpi-p.adoc
037544e 
Added DEV-33 to Table 1:10.1-1. SDPi-P Profile - Actors and Transactions
@JavierEspina
Update vol2-clause-appendix-a-mdpws-dev-33-getlocalizedtextresponse.xml
f486085 
Fixed line 7 of GetLocalizedTextResponse message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JavierEspina JavierEspina JavierEspina requested changes

@PaulMartinsen PaulMartinsen Awaiting requested review from PaulMartinsen

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Gemini SDPi Releases
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-gregorczyk @JavierEspina