Skip to content

🐛 Fix/web server rpc namespace #7815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 4, 2025

What do these changes do?

Create RPC namespaces associated to the docker service, not the image, otherwise the api-server can saturate the web-server

  • wb-api-server should only be communicated by the api-server
  • separate RPC namespace

Related issue/s

How to test

Dev-ops

@pcrespov pcrespov added this to the Bazinga! milestone Jun 4, 2025
@pcrespov pcrespov self-assigned this Jun 4, 2025
@pcrespov pcrespov added the release Preparation for pre-release/release label Jun 4, 2025
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 38.14433% with 60 lines in your changes missing coverage. Please review.

Project coverage is 79.17%. Comparing base (bfb0c98) to head (20be01b).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (bfb0c98) and HEAD (20be01b). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (bfb0c98) HEAD (20be01b)
unittests 32 29
integrationtests 6 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7815      +/-   ##
==========================================
- Coverage   86.74%   79.17%   -7.57%     
==========================================
  Files        1850     1797      -53     
  Lines       71934    69901    -2033     
  Branches     1218     1227       +9     
==========================================
- Hits        62401    55346    -7055     
- Misses       9191    14213    +5022     
  Partials      342      342              
Flag Coverage Δ
integrationtests 53.06% <50.00%> (-11.13%) ⬇️
unittests 79.73% <38.14%> (-6.77%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.92% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.13% <50.00%> (-0.02%) ⬇️
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.16% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 71.63% <0.00%> (-0.30%) ⬇️
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.09% <ø> (+0.05%) ⬆️
agent 96.29% <ø> (ø)
api_server 67.97% <100.00%> (-23.76%) ⬇️
autoscaling 96.03% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 51.09% <50.00%> (-39.91%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.08% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.00% <ø> (ø)
payments 92.50% <100.00%> (-0.07%) ⬇️
resource_usage_tracker ∅ <ø> (∅)
storage 87.50% <ø> (-0.04%) ⬇️
webclient ∅ <ø> (∅)
webserver 76.77% <100.00%> (-7.05%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb0c98...20be01b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov force-pushed the fix/web-server-rpc-namespace branch from 8b3ab57 to 20be01b Compare June 4, 2025 19:38
Copy link

sonarqubecloud bot commented Jun 4, 2025

@pcrespov pcrespov removed the release Preparation for pre-release/release label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant