Skip to content

removed module register from combo topics since its deprecated #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: vnext
Choose a base branch
from
Open

removed module register from combo topics since its deprecated #849

wants to merge 1 commit into from

Conversation

tishko0
Copy link
Contributor

@tishko0 tishko0 commented Jun 2, 2025

No description provided.

mddragnev
mddragnev requested changes Jun 2, 2025
View reviewed changes
Copy link
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove keys from all the samples.
Change using ref to using state in the samples that is appropriate. ( The samples that have switches

samples/inputs/combo/features/src/index.tsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove keys from the span.
Probably a better way to handle the switchs are to use state instead of ref

samples/inputs/combo/selection/src/index.tsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove keys here as well

samples/inputs/combo/styling/src/index.tsx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove keys here as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mddragnev mddragnev mddragnev requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tishko0 @mddragnev