-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(k8s): bundle support #4097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR prepares the Kubernetes Operator for distribution through OperatorHub by implementing bundle support and standardizing naming conventions. The primary change is renaming all references from k8-operator
to infisical-operator
across the codebase to comply with OperatorHub's strict naming requirements. The changes include:
- Updating import paths in all Go files to use the new package name
- Modifying Kubernetes resource labels and metadata
- Adding bundle generation and validation support in the Makefile
- Creating a new script (fix-csv.sh) to customize the ClusterServiceVersion manifest
This change is infrastructural in nature and doesn't modify the core functionality of the operator. It's a necessary step to enable automated releases to OperatorHub and improve the operator's accessibility to Kubernetes users.
Confidence score: 4.5/5
- This PR is safe to merge as it primarily involves package renaming and build infrastructure changes
- High confidence score given because the changes are well-structured, consistent across files, and don't affect runtime behavior
- Files needing attention:
k8-operator/scripts/fix-csv.sh
: New script that needs validation for correct CSV modificationk8-operator/Makefile
: Verify bundle generation targets work as expectedk8-operator/controllers/infisicaldynamicsecret/infisicaldynamicsecret_controller.go
: Contains TODO comments that should be addressed
48 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Description 📣
This PR adds bundle support to the Kubernetes Operator. This is a prerequisite for releasing to OperatorHub.
We had to rename from k8-operator -> infisical-operator for the generated output to match our Operator Hub release name. This is a hard requirement by their test suite.
I've created an initial release for operator hub, but after our initial release is out, we'll need to make a CI step to automate the release to operator hub.
Type ✨