Skip to content

Backend code cleanup #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 18, 2025
Merged

Backend code cleanup #2485

merged 9 commits into from
Jun 18, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 18, 2025 •
edited
Loading

The PR removes unused code from the backend:

  • DPNPC_id and DPNP_USM_iterator classes
  • LIBSYCL_VERSION_GREATER macro
  • broadcastable and get_validated_axes header functions
  • dpnp_iterator.hpp header file

GTests for removed functions are also cleaned up.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jun 18, 2025
@antonwolfy antonwolfy self-assigned this Jun 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.19.0dev0=py312h509198e_24 ran successfully.
Passed: 1231
Failed: 0
Skipped: 9

@antonwolfy antonwolfy marked this pull request as ready for review June 18, 2025 15:08
vtavana
vtavana approved these changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.863% (+0.2%) from 71.705%
when pulling 6fabb2d on backend-code-cleanup
into 7c2c8c2 on master.

@antonwolfy antonwolfy merged commit 0d01250 into master Jun 18, 2025
70 of 72 checks passed
@antonwolfy antonwolfy deleted the backend-code-cleanup branch June 18, 2025 19:21
github-actions bot added a commit that referenced this pull request Jun 18, 2025
@github-actions
Backend code cleanup (#2485)
812e8d5 
The PR removes unused code from the backend:

- `DPNPC_id` and `DPNP_USM_iterator` classes
- `LIBSYCL_VERSION_GREATER` macro
- `broadcastable` and `get_validated_axes` header functions
- `dpnp_iterator.hpp` header file

GTests for removed functions are also cleaned up. 0d01250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
0.19.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vtavana