Skip to content

1938 - 1 - Variant Name Change #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025
Merged

1938 - 1 - Variant Name Change #1989

merged 3 commits into from
Jul 17, 2025

Conversation

Cmdv
Copy link
Contributor

@Cmdv Cmdv commented Jul 16, 2025

Description

Splitting out #1938 into smaller PRs

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@Cmdv Cmdv requested a review from a team as a code owner July 16, 2025 15:55
@Cmdv Cmdv force-pushed the #1938-1-Variant-Name-Change branch from f90dc14 to 27c18a3 Compare July 16, 2025 15:57
@Cmdv Cmdv requested a review from a team as a code owner July 16, 2025 15:59
with:
version: "0.10.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@@ -45,8 +45,8 @@ import qualified System.Random as Random

{- HLINT ignore "Fuse on/on" -}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you didn't add this, but since you're already in there, you may as well remove this HLINT hint, since it is ignored globally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do one better and remove them all as it seems it's in 11 places 😗

@Cmdv Cmdv requested a review from sgillespie July 16, 2025 21:04
@Cmdv Cmdv merged commit 0c4fffa into master Jul 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants