Skip to content

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Oct 5, 2025

Description

This PR removes the size estimation functionality that is not used by anyone and is blocking #5045

The main goal of this PR is to remove Typeable constraint from EncCBOR, which is used with mkMemoized and is needed for all lenses. Removing Typeable constraint unblocks the attempt at nested transactions that is being worked on in #5334

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@lehins lehins mentioned this pull request Oct 7, 2025
23 tasks
@lehins lehins force-pushed the lehins/remove-size-from-enc-cbor branch from 6921a0e to 092a7a0 Compare October 8, 2025 00:51
@lehins lehins force-pushed the lehins/remove-size-from-enc-cbor branch from 092a7a0 to d048624 Compare October 8, 2025 00:51
@lehins lehins marked this pull request as ready for review October 8, 2025 00:51
@lehins lehins requested a review from a team as a code owner October 8, 2025 00:51
@lehins lehins force-pushed the lehins/remove-size-from-enc-cbor branch from d048624 to ab71bf0 Compare October 8, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant