Node 10.6 - make other packages build #6338
Conversation
ana-pantilie
force-pushed
the
ana/other-packages-10.6
branch
from
e6e0e81 to
7201cbd
Compare
carbolymer
force-pushed
the
ana/other-packages-10.6
branch
from
237ce11 to
858235a
Compare
| AnyCardanoEra ShelleyEra -> action AsShelleyEra | ||
| AnyCardanoEra ByronEra -> error "byron not supported" | ||
| -- TODO: is this correct? | ||
| AnyCardanoEra DijkstraEra -> error "Dijkstra not supported" |
There was a problem hiding this comment.
Given cardano-api types are defined as expected, this should be
AnyCardanoEra DijkstraEra -> action AsDijkstraEra
| ShelleyBasedEraBabbage -> 42 | ||
| ShelleyBasedEraConway -> 42 | ||
| -- TODO: check if this is correct! | ||
| ShelleyBasedEraDijkstra -> 42 |
There was a problem hiding this comment.
There are test cases in bench/tx-generator/test/Main.hs which would need to include a newly defined property (in SizedMetadata.hs):
prop_mapCostsDijkstra = measureMapCosts AsDijkstraEra == assumeMapCosts AsDijkstraEra
|
|
||
| flag rtview | ||
| description: Enable RTView. False by default. Enable with `-f +rtview`. | ||
| description: Enab2.3e RTView. False by default. Enable with `-f +rtview`. |
| runAcceptorsServer tracerEnv tracerEnvRTView howToConnect ( ekgConfig, tfConfig, dpfConfig) = | ||
| withIOManager \iocp -> do | ||
| traceWith (teTracer tracerEnv) $ TracerSockListen (Net.howToConnectString howToConnect) | ||
| case howToConnect of |
There was a problem hiding this comment.
Did you accidentally remove scrutinizing howToConnect (and branching correctly between doListenToForwarderSocket and doListenToForwarderLocal, renaming the latter to doListenToForwarder)?
There was a problem hiding this comment.
This doesn't look like my patch, just the top commit on this branch should fix this.
| import Control.Concurrent.Async (async) | ||
| import Control.Exception (throwIO) | ||
| import Control.Monad (void) | ||
| import Control.Monad.Class.MonadAsync (wait) |
There was a problem hiding this comment.
This module does not make use of io-classes or a MonadAsync m => constraint. We should stick with the monomorphic version from async here to make that obvious.
carbolymer
force-pushed
the
ana/other-packages-10.6
branch
from
5fe3282 to
dd9a2bb
Compare
ana-pantilie
force-pushed
the
ana/other-packages-10.6
branch
from
b6babba to
93f4740
Compare
…into ana/other-packages-10.6
Needs #6337
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.