TxSubmission Logic: integration #1522
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new method leverages a corresponding method recently exposed by ledger side to provide encoded transaction sizes to eg. diffusion layer.
Co-Author: Armando Santos <[email protected]> Co-Author: Marcin Szamotulski <[email protected]> Co-Author: Marcin Wójtowicz <[email protected]>
coot
force-pushed
the
coot/tx-submission-10.5
branch
from
15846cd to
b8dd378
Compare
amesgen
reviewed
May 26, 2025
Comment on lines
+97
to
+100
| , msExUnitsMemory :: !Natural | ||
| -- ^ The execution memory units of all the transactions in the mempool. | ||
| , msExUnitsSteps :: !Natural | ||
| -- ^ The execution steps of all the transactions in the mempool. |
There was a problem hiding this comment.
This MempoolSize is part of the abstract Cardano-agnostic Consensus layer, so it is a bit weird for it to directly mention Cardano-specific implementation details like script memory/steps (also see #1523). In particular, is it intentional that reference script size is missing here?
I think the more principled thing to do here would be to add TxMeasure as a field (which in particular contains the byte size, so that can also be removed).
Also, is this change actually related to the new TxSubmission logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description