Integration with ouroboros-network:cardano-diffusion #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
requested review from
nfrisby,
jasagredo,
amesgen,
fraser-iohk,
dnadales and
geo2a
as code owners
coot
commented
Jun 24, 2025
Comment on lines
427
to
433
| MustExist -> | ||
| -- create the file if it doesn't exist | ||
| void $ | ||
| hPut hasFS pHnd $ | ||
| Put.execPut $ | ||
| Put.putWord8 currentVersionNumber | ||
| <> putSecondaryOffset 0 |
| @@ -804,6 +804,7 @@ openPrimaryIndex cacheEnv chunk allowExisting = do | |||
| flip onException (hClose pHnd) $ do | |||
| newCurrentChunkInfo <- case allowExisting of | |||
| MustBeNew -> return $ emptyCurrentChunkInfo chunk | |||
| MustExist -> loadCurrentChunkInfo hasFS chunkInfo chunk | |||
coot
force-pushed
the
coot/cardano-diffusion-integration
branch
from
65e4a5d to
b6e8b42
Compare
geo2a
reviewed
Jun 25, 2025
| ouroboros-network-protocols | ||
| ouroboros-network-testing | ||
|
|
||
| source-repository-package |
There was a problem hiding this comment.
No need for an s-r-p on fs-sim, this revision is already on Hackage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description