Skip to content

Conversation

coot
Copy link
Contributor

@coot coot commented Sep 29, 2025

Description

  • dmq-node: added configuration option for local address
  • dmq-node: fixed a comment
  • scriv: added scriv-insert-here tag
  • dmq-node-0.2

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot coot requested a review from a team as a code owner September 29, 2025 09:26
@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Sep 29, 2025
@coot coot added the dmq-node Issues / PRs related to DMQ Node label Sep 29, 2025
@coot coot self-assigned this Sep 29, 2025
@coot coot enabled auto-merge September 29, 2025 09:28
@coot coot force-pushed the coot/dmq-ntc-socket branch from 1da596d to a221f1f Compare September 29, 2025 09:33
Copy link

@the-headless-ghost the-headless-ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot requested a review from a team as a code owner September 29, 2025 09:50
@coot coot disabled auto-merge September 29, 2025 10:53
@coot coot force-pushed the coot/dmq-ntc-socket branch from 70ea6a6 to 4e260d6 Compare September 29, 2025 11:14
@coot coot force-pushed the coot/dmq-ntc-socket branch 2 times, most recently from b6675aa to 422986e Compare September 30, 2025 07:11
@coot coot force-pushed the coot/dmq-ntc-socket branch from 422986e to 508d1d0 Compare September 30, 2025 08:05
@coot coot force-pushed the coot/dmq-ntc-socket branch 3 times, most recently from 9a8996f to abc6146 Compare October 3, 2025 11:32
coot added 3 commits October 3, 2025 13:40
* according to the CDDL there are only 4 fields rather than 7
* do not account the list len tag in the signed bytes
@coot coot force-pushed the coot/dmq-ntc-socket branch from abc6146 to 0a07626 Compare October 3, 2025 11:50
@coot coot force-pushed the coot/dmq-ntc-socket branch from eabbfa9 to c011000 Compare October 6, 2025 09:55
Both `TraceLocalMsgSubmission` & `TraceSendRecv` for
`localMsgSubmission` protocol are using the same configuration option
`dmqcLocalMsgSubmissionServerTracer`.
@coot coot force-pushed the coot/dmq-ntc-socket branch from 2c2f822 to d23fe95 Compare October 8, 2025 07:03
@coot coot force-pushed the coot/dmq-ntc-socket branch from d23fe95 to bb3749e Compare October 8, 2025 08:42
coot added 2 commits October 8, 2025 11:47
* only trace msgid
* removed polymorphism in `NodeToClient` module:
  - `NodeToClient.ntcApps` parametrised by `crypto` in a similar way `NodeToNode.ntnApps` is;
  - `NodeToClient.Codec` parametrised by `crypto` as `NodeToNode.Codec`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dmq-node Issues / PRs related to DMQ Node
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants