-
Notifications
You must be signed in to change notification settings - Fork 89
dmq-node: added node-to-client local socket configuration option #5203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coot
wants to merge
18
commits into
main
Choose a base branch
from
coot/dmq-ntc-socket
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+821
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1da596d
to
a221f1f
Compare
the-headless-ghost
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It can either be specified in the configuration file `localAddress` or with a command line switch `--local-address`.
70ea6a6
to
4e260d6
Compare
b6675aa
to
422986e
Compare
Added ToJSON instance for LocalTxSubmission messages
422986e
to
508d1d0
Compare
9a8996f
to
abc6146
Compare
* according to the CDDL there are only 4 fields rather than 7 * do not account the list len tag in the signed bytes
abc6146
to
0a07626
Compare
eabbfa9
to
c011000
Compare
Both `TraceLocalMsgSubmission` & `TraceSendRecv` for `localMsgSubmission` protocol are using the same configuration option `dmqcLocalMsgSubmissionServerTracer`.
2c2f822
to
d23fe95
Compare
It is off by default, since it's a debug tracer.
d23fe95
to
bb3749e
Compare
* only trace msgid * removed polymorphism in `NodeToClient` module: - `NodeToClient.ntcApps` parametrised by `crypto` in a similar way `NodeToNode.ntnApps` is; - `NodeToClient.Codec` parametrised by `crypto` as `NodeToNode.Codec`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scriv-insert-here
tagChecklist
Quality
Maintenance
ouroboros-network
project.