Skip to content

Disable for wasm everything that is disabled for windows #7362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable for wasm everything that is disabled for windows #7362

wants to merge 1 commit into from

Conversation

palas
Copy link
Contributor

@palas palas commented Sep 24, 2025

In the same way that they are disabled for windows, this PR disables tests and executables for wasm, since they currently don't work in wasm.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@palas palas requested a review from zeme-wana September 24, 2025 23:54
@palas palas self-assigned this Sep 24, 2025
@palas palas added the No Changelog Required Add this to skip the Changelog Check label Sep 24, 2025
@palas palas requested review from zliu41 and removed request for zeme-wana September 25, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zliu41 zliu41 Awaiting requested review from zliu41

At least 1 approving review is required to merge this pull request.

Assignees

@palas palas

Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@palas