-
Notifications
You must be signed in to change notification settings - Fork 1
Improvements, more safeguards #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @phil777 ! Looks good to me in general, but could you add some helper info to the added click options? Also, I'd prefer to keep the default behaviour of having tasknote edit the notes, maybe an option --visualize or --show could render the markdown?
Hi,
As you may guess, I prefer this behavior ;) Would you accept a configuration option for this? E.g. default_behavior={edit|show} ? |
that would work for me yes :) thanks! |
… already exists and no option is given
PR updated with things discussed above:
Also minor improvements
|
README.md
Outdated
|
||
```bash | ||
$ tasknote -a | ||
True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah!! Sorry I read too fast and I did not understand you spoke about the README the first time you pointed it to me! Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries :) thanks for the fix!
don't understand the github ui, but I merged your changes with d938a53 Thanks a lot for your help :) Your branch has no changes with respect to master, funny that github is not able to get that. |
Some improvements to fit my needs:
among other changes.
I bumped major version number since the API changed a bit.