Skip to content

Conversation

phil777
Copy link
Contributor

@phil777 phil777 commented Aug 17, 2025

Some improvements to fit my needs:

  • configuring task marks
  • getting list of tasks with notes
  • rendering notes as markdown

among other changes.

I bumped major version number since the API changed a bit.

Copy link
Owner

@Jimmy2027 Jimmy2027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @phil777 ! Looks good to me in general, but could you add some helper info to the added click options? Also, I'd prefer to keep the default behaviour of having tasknote edit the notes, maybe an option --visualize or --show could render the markdown?

Jimmy2027

This comment was marked as duplicate.

@phil777
Copy link
Contributor Author

phil777 commented Aug 28, 2025

Hi,

Also, I'd prefer to keep the default behaviour of having tasknote edit the notes, maybe an option --visualize or --show could render the markdown?

As you may guess, I prefer this behavior ;) Would you accept a configuration option for this? E.g. default_behavior={edit|show} ?

@Jimmy2027
Copy link
Owner

that would work for me yes :) thanks!

@phil777 phil777 closed this Aug 30, 2025
@phil777 phil777 reopened this Aug 30, 2025
@phil777
Copy link
Contributor Author

phil777 commented Aug 30, 2025

PR updated with things discussed above:

  • documented options
  • default back to edit mode, but configurable to view with default_behavior entry in config file

Also minor improvements

  • ability to give parameters to editor, so that we can call vim + file and start editing at the end of the file
  • horizontal line at the end of the displayed note
  • catch and write toml parsing errors instead of a big stack trace

README.md Outdated

```bash
$ tasknote -a
True
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
True

Copy link
Contributor Author

@phil777 phil777 Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah!! Sorry I read too fast and I did not understand you spoke about the README the first time you pointed it to me! Fixed.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries :) thanks for the fix!

@Jimmy2027
Copy link
Owner

don't understand the github ui, but I merged your changes with d938a53 Thanks a lot for your help :)

Your branch has no changes with respect to master, funny that github is not able to get that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants