Switch over to AK implementation for reductions #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - Fix extrema - Dims arrays - Multi-input
christiangnrd
force-pushed
the
akreduce
branch
from
c755f89 to
25627df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AK's
mapreduceis missing some features.TODO:
If we remove the
::AbstractArrayannotations in the AK reduction functions, tweakuse_KA_algoin AK (done Tweak backend selection AcceleratedKernels.jl#56), and defineKA.get_backend(::Broadcast.Broadcasted{<backendcontainer>})in each backend, the 1d function still errors when trying to convert theBroadcastedobject to a view.