Skip to content

Re-enable tests under validation. #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Re-enable tests under validation. #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ steps:
intel: "*"
commands: |
julia --project=deps deps/build_ci.jl
if: build.message !~ /\[skip tests\]/
if: build.message !~ /\[skip tests\]/ && build.message !~ /\[skip julia\]/
timeout_in_minutes: 120
matrix:
setup:
Expand Down Expand Up @@ -56,15 +56,14 @@ steps:
# use debug JLLs, for asserts + better backtraces
using oneAPI
oneAPI.set_debug!(true)'
if: build.message !~ /\[skip tests\]/
env:
ZE_ENABLE_VALIDATION_LAYER: '1'
ZE_ENABLE_PARAMETER_VALIDATION: '1'
EnableDebugBreak: '0'
agents:
queue: "juliagpu"
intel: "*"
if: build.message !~ /\[skip tests\]/ && !build.pull_request.draft
if: build.message !~ /\[skip tests\]/ && build.message !~ /\[skip special\]/ && !build.pull_request.draft
timeout_in_minutes: 60

env:
Expand Down
10 changes: 4 additions & 6 deletions test/onemkl.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,10 @@ k = 13
@test testf(axpy!, alpha, rand(T,m), rand(T,m))
end

if !validation_layer # oneapi-src/oneMKL#473
@testset "axpby" begin
alpha = rand(T)
beta = rand(T)
@test testf(axpby!, alpha, rand(T,m), beta, rand(T,m))
end
@testset "axpby" begin
alpha = rand(T)
beta = rand(T)
@test testf(axpby!, alpha, rand(T,m), beta, rand(T,m))
end

@testset "rotate" begin
Expand Down
8 changes: 3 additions & 5 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,9 @@ for (rootpath, dirs, files) in walkdir(@__DIR__)
end
end
## GPUArrays testsuite
if !validation_layer # oneapi-src/oneMKL#473
for name in keys(TestSuite.tests)
push!(tests, "gpuarrays$(Base.Filesystem.path_separator)$name")
test_runners["gpuarrays$(Base.Filesystem.path_separator)$name"] = ()->TestSuite.tests[name](oneArray)
end
for name in keys(TestSuite.tests)
push!(tests, "gpuarrays$(Base.Filesystem.path_separator)$name")
test_runners["gpuarrays$(Base.Filesystem.path_separator)$name"] = ()->TestSuite.tests[name](oneArray)
end
unique!(tests)

Expand Down