Skip to content

Revised: parametrize struct definitions of random matrix ensemble types #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 22, 2025

Conversation

apkille
Copy link
Contributor

@apkille apkille commented Jun 12, 2025

Revised version of #96. Parametrizes ensemble type definitions by their Dyson index β, while making some changes proposed in #91.

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 61.32075% with 41 lines in your changes missing coverage. Please review.

Project coverage is 46.49%. Comparing base (37f177b) to head (fbdb057).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/HaarMeasure.jl 18.91% 30 Missing ⚠️
src/GaussianEnsembles.jl 80.35% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   42.65%   46.49%   +3.84%     
==========================================
  Files          12       12              
  Lines         830      856      +26     
==========================================
+ Hits          354      398      +44     
+ Misses        476      458      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apkille
Copy link
Contributor Author

apkille commented Jun 12, 2025

@dlfivefifty

@dlfivefifty
Copy link
Member

Looks good but can you get the codecov up?

@apkille
Copy link
Contributor Author

apkille commented Jun 22, 2025

@dlfivefifty should be good to go. I'd like to deal with the remaining missing tests in separate PRs.

@dlfivefifty dlfivefifty merged commit 365bd5b into JuliaMath:master Jun 22, 2025
8 checks passed
@apkille apkille deleted the param branch June 22, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants