WIP: Endpoint() constructor: Roundtrip the URL through URIs.resolvereference(), and make sure it is unchanged
#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
force-pushed
the
dpa/resolvereference
branch
2 times, most recently
from
3823787 to
77282c6
Compare
…rence()`, and make sure it is unchanged
DilumAluthge
force-pushed
the
dpa/resolvereference
branch
from
1bd86c8 to
8072388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves as an additional sanity check that the endpoint URL doesn't contain any path traversal.
On its own, I don't think this is sufficient, so I think we should still keep the existing checks.