Skip to content

Fixed unsafe dictionary accesses in the update_integration_instance_config_value #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Fixed unsafe dictionary accesses in the update_integration_instance_config_value #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64225df
Fixed unsafe dictionary accesses in the `update_integration_instance_…
CraigBryan Feb 28, 2025
1e0f6d2
Merge branch 'main' into feat/fix_integration_config_updating
SeaBlooms Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions jupiterone/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,14 @@

import json
from warnings import warn
from typing import Dict, List
from typing import Dict, List, Union
from datetime import datetime
import time

import re
import requests
from requests.adapters import HTTPAdapter, Retry
from retrying import retry
from typing import Union, List

from jupiterone.errors import (
JupiterOneClientError,
Expand Down Expand Up @@ -703,7 +702,10 @@
instance_config["data"]["integrationInstance"]["config"] = config_dict

# remove externalId to not include in update payload
del instance_config["data"]["integrationInstance"]["config"]["externalId"]
if "externalId" in instance_config["data"]["integrationInstance"]["config"]:
del instance_config["data"]["integrationInstance"]["config"][
"externalId"
]

# prepare variables GraphQL payload for updating config
instance_details = instance_config["data"]["integrationInstance"]
Expand All @@ -726,12 +728,18 @@
}

# remove problem fields from previous response
del variables["update"]["pollingIntervalCronExpression"]["__typename"]
if variables["update"].get("pollingIntervalCronExpression") is not None:
if "__typename" in ["update"]["pollingIntervalCronExpression"]:
del variables["update"]["pollingIntervalCronExpression"][
"__typename"
]

for ingestion_source in instance_details["ingestionSourcesOverrides"]:
ingestion_source.pop(
"__typename", None
) # Removes key if it exists, ignores if not
ingestion_sources = instance_details.get("ingestionSourcesOverrides", None)
if ingestion_sources is not None:
for ingestion_source in instance_details["ingestionSourcesOverrides"]:
ingestion_source.pop(
"__typename", None
) # Removes key if it exists, ignores if not

response = self._execute_query(
UPDATE_INTEGRATION_INSTANCE, variables=variables
Expand Down
Loading