Skip to content

Adjust window box for GTK HeaderBar #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 56 additions & 5 deletions src/pywinbox/_pywinbox_linux.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

from Xlib.xobject.drawable import Window as XWindow
from ._main import Box

from ewmhlib import EwmhWindow


Expand All @@ -26,12 +27,62 @@ def _getWindowBox(handle: EwmhWindow) -> Box:
# https://stackoverflow.com/questions/12775136/get-window-position-and-size-in-python-with-xlib
geom = handle.xWindow.get_geometry()
pos = handle.root.translate_coords(handle.id, 0, 0)
return Box(pos.x, pos.y, geom.width, geom.height)

# check if application uses special title bar (a.k.a. GTK HeaderBar)
# see: https://docs.gtk.org/gtk4/class.HeaderBar.html
# if it has HeaderBar (e.g., gedit):
# top left will be top left including extra space (shadows?)
# in that case, we subtract gtk extents to the right box
# if it doesn't (e.g., gvim):
# top left will be top left of client window (i.e., excluding the title bar)
# in that case, we add the title bar to get the right box

_net_extents = handle._getNetFrameExtents()
_gtk_extents = handle._getGtkFrameExtents()
if _net_extents and len(_net_extents) >= 4:
# this means it has no GTK HeaderBar
x = pos.x - int(_net_extents[0])
y = pos.y - int(_net_extents[2])
w = geom.width + int(_net_extents[0]) + int(_net_extents[1])
h = geom.height + int(_net_extents[2]) + int(_net_extents[3])
elif _gtk_extents and len(_gtk_extents) >= 4:
# this means there is a GTK HeaderBar
x = pos.x + int(_gtk_extents[0])
y = pos.y + int(_gtk_extents[2])
w = geom.width - int(_gtk_extents[0]) - int(_gtk_extents[1])
h = geom.height - int(_gtk_extents[2]) - int(_gtk_extents[3])
else:
# something else: best guess is to trust pos and geom from above
# NOTE: if you have this case and are not getting the expected result,
# please open an issue: https://github.com/Kalmat/PyWinBox/issues/new
x = pos.x
y = pos.y
w = geom.width
h = geom.height
return Box(x, y, w, h)


def _moveResizeWindow(handle: EwmhWindow, newBox: Box):
newLeft = max(0, newBox.left) # Xlib won't accept negative positions
newTop = max(0, newBox.top)
handle.setMoveResize(x=newLeft, y=newTop, width=newBox.width, height=newBox.height, userAction=True)
# handle.configure(x=newLeft, y=newTop, width=newBox.width, height=newBox.height)
_net_extents = handle._getNetFrameExtents()
_gtk_extents = handle._getGtkFrameExtents()
if _net_extents and len(_net_extents) >= 4:
# seems that top left includes window borders, but width and height does not
newLeft = newBox.left
newTop = newBox.top
newWidth = newBox.width - int(_net_extents[0]) - int(_net_extents[1])
newHeight = newBox.height - int(_net_extents[2]) - int(_net_extents[3])
elif _gtk_extents and len(_gtk_extents) >= 4:
newLeft = newBox.left - int(_gtk_extents[0])
newTop = newBox.top - int(_gtk_extents[2])
newWidth = newBox.width + int(_gtk_extents[0]) + int(_gtk_extents[1])
newHeight = newBox.height + int(_gtk_extents[2]) + int(_gtk_extents[3])
else:
newLeft = newBox.left
newTop = newBox.top
newWidth = newBox.width
newHeight = newBox.height

newLeft = max(0, newLeft) # Xlib won't accept negative positions
newTop = max(0, newTop)
handle.setMoveResize(x=newLeft, y=newTop, width=newWidth, height=newHeight, userAction=True)
# handle.configure(x=newLeft, y=newTop, width=newBox.width, height=newBox.height)