Fix Position Line gradient appearing in all editors no matter which one is playing #7882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see no problem good job |
messmerd
approved these changes
Jun 2, 2025
bratpeki
approved these changes
Jun 3, 2025
|
Works good and other devs say it's made good, please merge! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in master, if you zoom in on both the song editor and the piano roll, then play either of them, both playhead/position lines will have their gradient/tail appear, even though only one of them is playing.
This is because the position line only checks if either the song or a midi clip is playing, as it doesn't directly know which editor it belongs to.
I fixed this issue by adding the PlayMode for the position line as an argument in its constructor, which it can use to check whether it's corresponding editor is playing, and if so, show the gradient.