-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use C++20 in RemoteVstPlugin
#7916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Also avoid using std::wstring due to strange issues with it when built with wineg++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this seems to have fixed the crash in #7624, and the code changes look fine to me. Seems ready for merge 👍
@sakertooth Thanks! I noticed an issue when trying to open 64-bit OTT though, and it didn't seem to be happening on master, so I'd like to investigate that first |
Did a quick test run and also noticed a strange deadlock that I usually don't get in the |
Reland C++20 mode compilation for
RemoteVstPlugin
std::wstring
on wineg++ by usingstd::unique_ptr<wchar_t[]>
instead. See my comment here. This fixed theRemoteVstPlugin
crash in C++20 mode.RemoteVstPlugin
cleanupstd::unique_ptr
or stack-allocated objectspluginDispatch
constantsstd::int16_t
instead ofshort
VstSyncData
member namesF_OPEN_UTF8
tofopenUtf8
since it's not a macro anymoredetermine_version_from_source
CMake functionIoHelper.h
header to buildKnown issues: