Refactor Global Spacebar Play #7926
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies #7762 by removing the editor-specific code from
MainWindow
andm_lastPlayMode
fromSong
, and instead uses a static variable inEditor
which keeps track of the last played editor.This PR also removes the spacebar shortcut from
MixerChannelView
for changing the volume, as multiple users have noticed that it clashes with their intuition after getting used to the spacebar working everywhere else.