Skip to content

Refactor Global Spacebar Play #7926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

regulus79
Copy link
Contributor

This PR simplifies #7762 by removing the editor-specific code from MainWindow and m_lastPlayMode from Song, and instead uses a static variable in Editor which keeps track of the last played editor.

This PR also removes the spacebar shortcut from MixerChannelView for changing the volume, as multiple users have noticed that it clashes with their intuition after getting used to the spacebar working everywhere else.

@regulus79 regulus79 mentioned this pull request Jun 2, 2025
@sakertooth
Copy link
Contributor

Could we also undo the error-prone event propagation as well? Each widget can have their own keyPressEvent, and each decide what it should do when the spacebar is pressed. Most widgets can then just decide to play the editor.

@sakertooth
Copy link
Contributor

Could we also undo the error-prone event propagation as well? Each widget can have their own keyPressEvent, and each decide what it should do when the spacebar is pressed. Most widgets can then just decide to play the editor.

Actually, maybe its fine, I just want to prevent bugs like #7915 from happening.

@bratpeki
Copy link
Member

bratpeki commented Jun 2, 2025

Ready for testing?

@bratpeki bratpeki self-assigned this Jun 2, 2025
@regulus79
Copy link
Contributor Author

Yes! The only visible change should be that the mixer channels don't respond to the spacebar anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants