refactor: remove redistribution delay #1485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
changed the title
SlashEscrowFactory
ypatil12
reviewed
Jun 26, 2025
wadealexc
reviewed
Jun 27, 2025
ypatil12
requested changes
Jul 1, 2025
ypatil12
reviewed
Jul 1, 2025
0xClandestine
force-pushed
the
release-dev/redistribution-changes
branch
from
ead84ff to
313afe1
Compare
0xClandestine
force-pushed
the
refactor/remove-slash-escrow
branch
from
f284dbd to
82e552b
Compare
nadir-akhtar
reviewed
Jul 1, 2025
ypatil12
reviewed
Jul 1, 2025
wadealexc
reviewed
Jul 2, 2025
| } | ||
|
|
||
| /** | ||
| * @dev This empty reserved space is put in place to allow future versions to add new | ||
| * variables without shifting down storage in the inheritance chain. | ||
| * See https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps | ||
| */ | ||
| uint256[35] private __gap; | ||
| uint256[31] private __gap; |
There was a problem hiding this comment.
Correct gap, we only use 3 more slots
wadealexc
approved these changes
Jul 2, 2025
0xClandestine
merged commit 8cff169
into
release-dev/redistribution-changes
14 checks passed
0xClandestine
added a commit
that referenced
this pull request
Jul 2, 2025
**Motivation:** We've decided we do not want delays on redistributions. **Modifications:** - Removed `SlashEscrowFactory` + `SlashEscrow` and all relevant changes. **Result:** Tokens are immediately redistributed upon calling `clearBurnOrRedistributableShares`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We've decided we do not want delays on redistributions.
Modifications:
SlashEscrowFactory+SlashEscrowand all relevant changes.Result:
Tokens are immediately redistributed upon calling
clearBurnOrRedistributableShares.