Adding ShivamShukla.java File #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swarnsingh
requested changes
Aug 17, 2018
| import java.util.regex.*; | ||
|
|
||
| class Shivam | ||
| { |
There was a problem hiding this comment.
Please do proper formatting in your code & import specific classes instead of import the whole package.
olleh423
reviewed
Aug 18, 2018
| String temp=t; | ||
| Scanner sc=new Scanner(System.in); | ||
| int i; | ||
| String a[]=new String[100]; |
There was a problem hiding this comment.
Avoid static allocation. if n is 5 then the rest of the memory will be wasted. if n will go more than 100 it will throw IndexOutOfBoundException.
olleh423
reviewed
Aug 18, 2018
| for(i=0;i<n;i++) | ||
|
|
||
| { | ||
| for(int j=-1;(j=temp.indexOf(a[i],j+1)) !=-1;) |
There was a problem hiding this comment.
Try not to use predefined methods like indexOf(). Instead you can iterate the input and match characters.
olleh423
reviewed
Aug 18, 2018
|
|
||
| import java.util.regex.*; | ||
|
|
||
| class Shivam |
There was a problem hiding this comment.
Improper indentation. Please correct
olleh423
reviewed
Aug 18, 2018
|
|
||
| String text=sc.nextLine(); | ||
|
|
||
| n=Integer.parseInt(sc.nextLine()); |
There was a problem hiding this comment.
Use sc.nextInt() instead of Integer.parseInt(sc.nextLine());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.