Skip to content

Onboard all NOAA parameters. Separates parameter validation, query building, updated docs #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Onboard all NOAA parameters. Separates parameter validation, query building, updated docs #16

wants to merge 4 commits into from

Conversation

doswal
Copy link
Collaborator

@doswal doswal commented Sep 4, 2025

Fixes #11

Changes:

  • Add pending parameters from NOAA Paleo Data API.
  • Add validations as per API
  • Add query builder
  • Isolate API request logic from core Dataset logic

@doswal
1. Adding the remaining primary parameters for search. 2. Adding disp…
d79f9c5 
…lay toggle
@doswal
Add wanrning when search_studies repsonse length matches limits
3f0cd04
@doswal
1. Separate API request logic from Dataset by Adding param validators…
0f03dff 
…, query builders, constants. (Motivation: Will be helpful to extend code base to Pangaea) 2. SUpport multi valued parameters by changing input type to str/list[str], coercing list values to a string using |(pipe) and adding respetive {name}AndOr flag to query. 3. Set base towards using logging package. 4. Change input params with kwargs.
@doswal
Updating docstrings with examples and correct parameter details
10d7359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable the rest of the NOAA search parameters
1 participant
@doswal