build(windows): add arm64 initial support #3905

rbqvq · 2025-05-25T08:30:17Z

Description

This PR adds an arm64 build for Windows.

Todo:

Cross compile build-deps for arm
Some dependencies not available in clang-aarch64 environment
- NSIS not available for ARM64... How to create installer? Sunshine: change windows installer to WiX roadmap#76
- MinHook does not support ARM64... excluded this library and disabled code that used it
- Boost issues (See commits)

Screenshot

Issues Fixed or Closed

Fixes LLVM Clang Build fails #4102

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Dependency update (updates to dependencies)
Documentation update (changes to documentation)
Repository update (changes to repository files, e.g. .github/...)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Question

Should we need disable all x86 hardware accel (nvenc, intel quicksync and amdvce) on windows arm64 build?

rbqvq · 2025-05-25T08:31:02Z

Known Issues

It crashed after moonlight connect

[2025-05-25 12:58:21.029]: Info: [libx264 @ 0000024346e9af20] kb/s:629.76
[2025-05-25 12:58:21.059]: Info:
Device Description : Qualcomm(R) Adreno(TM) 8cx Gen 3
Device Vendor ID   : 0x4D4F4351
Device Device ID   : 0x36333630
Device Video Mem   : 0 MiB
Device Sys Mem     : 1 MiB
Share Sys Mem      : 16081 MiB
Feature Level      : 0x0000B100
Capture size       : 2560x1440
Offset             : 0x0
Virtual Desktop    : 2560x1440
[2025-05-25 12:58:21.059]: Info: Active GPU has HAGS disabled
[2025-05-25 12:58:21.059]: Info: Using realtime GPU priority
[2025-05-25 12:58:21.059]: Info:
Colorspace         : DXGI_COLOR_SPACE_RGB_FULL_G22_NONE_P709
Bits Per Color     : 8
Red Primary        : [0.673828,0.317383]
Green Primary      : [0.280273,0.660156]
Blue Primary       : [0.142578,0.0449219]
White Point        : [0.313477,0.329102]
Min Luminance      : 0.0745 nits
Max Luminance      : 445.761 nits
Max Full Luminance : 445.761 nits
[2025-05-25 12:58:21.059]: Info: Desktop resolution [2560x1440]
[2025-05-25 12:58:21.060]: Info: Desktop format [DXGI_FORMAT_B8G8R8A8_UNORM]
[2025-05-25 12:58:21.060]: Info: Display refresh rate [119.987Hz]
[2025-05-25 12:58:21.060]: Info: Requested frame rate [60fps]
[2025-05-25 12:58:21.065]: Info:
[2025-05-25 12:58:21.065]: Info: // Ignore any errors mentioned above, they are not relevant. //
[2025-05-25 12:58:21.065]: Info:
[2025-05-25 12:58:21.065]: Info: Found H.264 encoder: libx264 [software]
[2025-05-25 12:58:21.065]: Info: Executing [Desktop]
[2025-05-25 12:58:21.182]: Info: New streaming session started [active sessions: 1]
libc++abi: terminating due to uncaught exception of type boost::wrapexcept<std::out_of_range>: config out of range

docs/getting_started.md

ReenigneArcher · 2025-05-25T14:18:53Z

src/config.cpp

The changes in this file don't make sense.

clangarm64 not support std
must use ::std

its necessary for clangarm64

What about the other hundreds of files?

There is no problem.

After changing this file, clangarm64 works correctly

I think it only happend in config::amd namespace, might it same error on x86?
Can u check it on Clang64?

that's a great resolution

the problem is actually caused by ln 115-117 in config.cpp. it imports headers in namespace amd, and the headers include std headers, which makes std redefine in namespace amd:

Sunshine/src/config.cpp

Lines 115 to 117 in a3ee774

#include <AMF/components/VideoEncoderAV1.h>

#include <AMF/components/VideoEncoderHEVC.h>

#include <AMF/components/VideoEncoderVCE.h>

src/platform/windows/audio.cpp

docs/building.md

cmake/dependencies/windows.cmake

.github/workflows/CI.yml

docs/getting_started.md

rbqvq · 2025-06-02T08:09:44Z

Can we use this hardware encode? 🤔
obsproject/obs-studio#11993

ReenigneArcher · 2025-06-02T12:52:36Z

I think MF encoder is already included with the FFmpeg build, so why not?

rbqvq · 2025-06-02T15:43:02Z

I think MF encoder is already included with the FFmpeg build, so why not?

Well, I didn't read the source code of sunshine.
This part is up to you. 🤪

ReenigneArcher · 2025-07-02T01:13:55Z

ci has been refactored a bit, the windows build is now in a separate workflow. It's already setup for a matrix build so should be easy to adapt your changes.

cgutman · 2025-07-05T16:54:52Z

src/platform/windows/display_base.cpp

+
+// conditional includes
+#if defined(__x86_64) || defined(__x86_64__) || defined(__amd64) || defined(__amd64__) || defined(_M_AMD64)
+  #include <MinHook.h>


I don't think we can/should do this. It might work now by luck because none of the Windows ARM64 machines out in the wild have a discrete GPU, but it is definitely not guaranteed to continue working. We should look into hooking libraries that support ARM64, like Detours.

MediaTek + NVIDIA SoCs in 2026
I'm not sure if this is integrated or discrete graphics.
At least until then, we don't have to do this.
We don't have any discrete GPU drivers for windows on arm

Step by step, complete the initial support first

MinHook does not support arm64, add conditional check Signed-off-by: Coia Prant <[email protected]> Co-authored-by: ReenigneArcher <[email protected]>

Steam Audio Driver unavailable on Windows Arm64, add check Signed-off-by: Coia Prant <[email protected]>

For AMF `#include`, clang will resolve `std` to `config::amd::std` Use `::std` to force resolution to the global namespace Signed-off-by: Coia Prant <[email protected]> Co-authored-by: Ricky8955555 <[email protected]>

SyntheticPointerDevice does not support arm64, add conditional check Signed-off-by: Coia Prant <[email protected]>

CLANGARM64 does not have libatomic which used by googletest, disable it Signed-off-by: Coia Prant <[email protected]>

Boost v1.87.0 is not currently compatible with WoA, backport the following context: Support building assembly files for mingw-w64 on arm64 with CMake Link: boostorg/context@f82483d uuid: Do not link to libatomic under any Clang/Windows Link: boostorg/uuid@434329f Signed-off-by: Coia Prant <[email protected]>

Add windows arm64 documents. Signed-off-by: Coia Prant <[email protected]> Co-authored-by: ReenigneArcher <[email protected]>

nsis does not support arm64, so we cannot create an installer at this time Signed-off-by: Coia Prant <[email protected]> Co-authored-by: ReenigneArcher <[email protected]>

Add missing TOSTRING for ICON Signed-off-by: Coia Prant <[email protected]>

sonarqubecloud · 2025-07-22T19:44:37Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rbqvq force-pushed the master branch 4 times, most recently from 0ccee19 to 4039fec Compare May 25, 2025 10:23

ReenigneArcher reviewed May 25, 2025

View reviewed changes

rbqvq force-pushed the master branch 2 times, most recently from b158d6d to 283ab4c Compare May 25, 2025 15:34

This was referenced May 26, 2025

refactor(installer/windows): move nsis code #3915

Merged

feat(installer/windows): add wix installer #3916

Draft

rbqvq force-pushed the master branch from 283ab4c to f5f8ad8 Compare June 2, 2025 17:14

This comment was marked as resolved.

Sign in to view

rbqvq force-pushed the master branch 11 times, most recently from 9d0c82c to b0e2234 Compare June 9, 2025 09:53

rbqvq force-pushed the master branch 2 times, most recently from 48376c4 to a3ee774 Compare June 30, 2025 05:21

rbqvq force-pushed the master branch from a3ee774 to cf8d908 Compare July 2, 2025 09:44

rbqvq force-pushed the master branch from cf8d908 to 70f23f8 Compare July 2, 2025 09:47

cgutman requested changes Jul 5, 2025

View reviewed changes

rbqvq and others added 5 commits July 22, 2025 19:01

fix(build): Enable minhook only on x86_64

bd1d49c

MinHook does not support arm64, add conditional check Signed-off-by: Coia Prant <[email protected]> Co-authored-by: ReenigneArcher <[email protected]>

fix(build): add check for Steam Audio Driver

8d0d9e6

Steam Audio Driver unavailable on Windows Arm64, add check Signed-off-by: Coia Prant <[email protected]>

fix(build): add compatibility for clang

e8c62fc

For AMF `#include`, clang will resolve `std` to `config::amd::std` Use `::std` to force resolution to the global namespace Signed-off-by: Coia Prant <[email protected]> Co-authored-by: Ricky8955555 <[email protected]>

fix(build): Declare SyntheticPointerDevice only on x86_64

c299f9a

SyntheticPointerDevice does not support arm64, add conditional check Signed-off-by: Coia Prant <[email protected]>

fix(build): Disable test for windows arm64

ea61996

CLANGARM64 does not have libatomic which used by googletest, disable it Signed-off-by: Coia Prant <[email protected]>

rbqvq force-pushed the master branch 3 times, most recently from 6862e9c to b720ab7 Compare July 22, 2025 19:10

rbqvq and others added 2 commits July 22, 2025 19:12

docs(windows): add documents for arm64

9c6fedc

Add windows arm64 documents. Signed-off-by: Coia Prant <[email protected]> Co-authored-by: ReenigneArcher <[email protected]>

rbqvq force-pushed the master branch from b720ab7 to 56eec5f Compare July 22, 2025 19:13

ci(build/windows): add support for arm64

de22b27

nsis does not support arm64, so we cannot create an installer at this time Signed-off-by: Coia Prant <[email protected]> Co-authored-by: ReenigneArcher <[email protected]>

rbqvq force-pushed the master branch from 56eec5f to de22b27 Compare July 22, 2025 19:13

fix: clang llvm parse error

885acc7

Add missing TOSTRING for ICON Signed-off-by: Coia Prant <[email protected]>

	#include <AMF/components/VideoEncoderAV1.h>
	#include <AMF/components/VideoEncoderHEVC.h>
	#include <AMF/components/VideoEncoderVCE.h>

Uh oh!

build(windows): add arm64 initial support #3905

Are you sure you want to change the base?

build(windows): add arm64 initial support #3905

Uh oh!

Conversation

rbqvq commented May 25, 2025 • edited by ReenigneArcher Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshot

Issues Fixed or Closed

Type of Change

Checklist

Question

Uh oh!

rbqvq commented May 25, 2025

Known Issues

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rbqvq May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rbqvq commented Jun 2, 2025

Uh oh!

ReenigneArcher commented Jun 2, 2025

Uh oh!

rbqvq commented Jun 2, 2025

Uh oh!

This comment was marked as resolved.

ReenigneArcher commented Jul 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rbqvq Jul 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 22, 2025

Quality Gate passed

Uh oh!

Uh oh!

rbqvq commented May 25, 2025 •

edited by ReenigneArcher

Loading

rbqvq May 25, 2025 •

edited

Loading

rbqvq Jul 5, 2025 •

edited

Loading