Skip to content

Add webViewRef to YoutubeIframe #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AliRezaBeigy
Copy link

Adds webViewRef prop to YoutubeIframe for direct WebView access, with TypeScript support. Updates index.d.ts and src/YoutubeIframe.js to include the prop and fallback logic.

@@ -2,7 +2,7 @@
"name": "react-native-youtube-iframe",
"version": "2.3.0",
"description": "A simple wrapper around the youtube iframe js API for react native",
"main": "dist/index.js",
"main": "src/index.js",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to rollback

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do that if the maintainer check the pr, now we use the fork version directly in package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants