Refactor factorio-mod-api data models #81
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you mean to add a commit to this that starts on the refactoring? |
|
Yes, I‘ve created this commit to start the refactoring (only with a commit I can create a PR) and so that I don’t forget to modify the changelog again. I‘ve marked this refactoring and the change to the download mod method as incompatible because it breaks (will break) existing implementations |
|
Ok. Just assume that this is going to lead to conflicts that you'll have to merge :-) |
|
Yep, I think I’ll wait until #82 ist merged and then begin with the breaking changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #69
This is still a draft to track progress on the refactoring