Bug fixes to MPAS->Albany mesh converter #338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With these changes, the GLF difference between MALI and standalone Albany is down to 10 digits of precision * write also the labels (floating/dirichlet) for boundary edges and nodes * print the mesh and ascii files in double precision. * Fix a small bug in the MPAS interface. In some very peculiar cases we set the thickness to 2 or 3 meters. Then we change accordingly the surface elevation in those location to comply with the floating point condition. However, instead of setting h = (1-rho_i/rho_o) H, we were setting h = (rho_o/rho_i -1) H. The impact on the GLF is small, 10e-6 relative error or so, but better to fix it.
|
Note: this PR to be replaced by a more extensive update to the interface code in progress by @mperego . |
|
Replaced by #402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge fixes some small bugs in the MPAS->Albany mesh converter. With these changes, the grounding line flux difference between MALI and standalone Albany is down to 10 digits of precision.