Do not zero N under floating ice in Interface #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes code that zeros effective pressure beneath floating ice in the Interface to Albany. This is unneeded because Albany zeros beta at quadrature points, and zeroing it here at FEM nodes interferes with that. At best it's redundant, and at worst (which is if N were to be assigned nonzero values under floating ice), it results in significant errors in the solve. This is also redundant because MPAS hydro model and ocean_connection_N parameterization will already zero N under floating ice.
This is needed because the friction laws that use effective pressure need N on the first floating cell to allow for more accurate evaluation of friction at quadrature points. Also, this commit moves the limiting of the effective pressure from the velocity_external routine to the calc_beta routine. Finally, all these manipulations to N are done on the field effectivePressureLimited to avoid messing up effectivePressure which is used by the subglacial hydrology model (if on).
This hack sets N=mu*N before passing N to Albany. This is hack to get Albany to only evaluate mu*N at cell centers rather than at all quadrature points. This hack is used for doing a forward run where mu is calculated from an MPAS N field. In this configuration, the albany input file should mu be spatially uniform with a value of 1.0. This commit should be removed or formalized before this branch is merged!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes code that zeros effective pressure beneath floating
ice in the Interface to Albany. This is unneeded because Albany zeros
beta at quadrature points, and zeroing it here at FEM nodes interferes
with that. At best it's redundant, and at worst (which is if N were to
be assigned nonzero values under floating ice), it results in
significant errors in the solve. This is also redundant because MPAS
hydro model and ocean_connection_N parameterization will already zero N
under floating ice.
The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).
Enter a description of this PR. This should include why this PR was created, and what it does.
Testing and relations to other Pull Requests should be added as subsequent comments.
See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931