Change three init mode namelist options #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
added
ocean
MPAS-Model PR required
xylar
changed the title
mark-petersen
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Tested with gnu 5.3 on grizzly with this PR and MPAS-Dev/MPAS-Model#825. Works, was able to compare bfb with ocean/develop and the current legacy branch.
|
@cbegeman, would you like to review this now or wait until MPAS-Dev/MPAS-Model#825 gets merged to |
cbegeman
approved these changes
Mar 23, 2021
Any test cases that use the Haney-number constrained coordinate need to use the new namelist option: config_init_vertical_grid_type = 'haney-number'
These namelist options can also be used for top cells.
The latest ocean/develop is needed in order for these COMPASS changes to work properly.
xylar
force-pushed
the
min_level_cell_phase_1
branch
from
faa45c7 to
fffbad4
Compare
|
I updated the submodule following the merge of MPAS-Dev/MPAS-Model#825 and will merge this PR as soon as tests complete. |
xylar
added
MPAS-Model PR finished
|
Thanks, @xylar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with MPAS-Dev/MPAS-Model#825, The following namelist changes are needed:
config_alter_ICs_for_pbcs-->config_alter_ICs_for_pbs(to support both top and bottom cells)config_pbc_alteration_type-->config_pc_alteration_typeconfig_use_rx1_constraint = .true.-->config_init_vertical_grid_type = 'haney-number'(to support a newz-levelvertical grid)