-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add test-runner functionality #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
svishnus
commented
Sep 10, 2025
- Test Runner integration with CI
Copies over existing benchmarking scripts with appropriate modifications to their respective .mlb files.
Would it be possible to run tests by checking out |
|
@svishnus @Forthoney my one request would just be to keep the benchmark sources outside of |
I was actually thinking of freezing the scripts we have in this repo and think of them as rudimentary tests (compiling properly, not segfaulting) rather than benchmarks. It just happened to be that the benchmarks repo had the most diverse set of realistic programs. If we have new benchmarks or optimizations to the algos in the benchmarks, these would not reflect it since they are for correctness. |
Gotcha -- this makes sense but I worry that the code duplication will become a problem. Inevitably, updates will happen in one place and we will want to port them across... we'll end up with duplicated work and/or inconsistent versions. Rather than vendor the frozen benchmarks, we could accomplish the same by hardcoding a particular commit of And, this would move in the direction of making |