-
Notifications
You must be signed in to change notification settings - Fork 408
Fix Fairy Elf bow requirements in initial weapon data and add migration plugin #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: sven-n <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Nicely done. Can you add another plugin like FixItemRequirementsPlugIn, so that the configurations which got created in the mean time, will get fixed, too?
Co-authored-by: sven-n <[email protected]>
Added Commit: 9b7149a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Please set the correct date, then we can accept this PR :)
| public override bool IsMandatory => true; | ||
|
|
||
| /// <inheritdoc /> | ||
| public override DateTime CreatedAt => new(2024, 12, 17, 12, 0, 0, DateTimeKind.Utc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set the current date here, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set the CreatedAt date to the current date (2025-09-16 19:44:00 UTC).
Commit: 3465a1b
Co-authored-by: sven-n <[email protected]>
✅ Completed: Fixed Fairy Elf bow requirements issue in OpenMU
Weapons.cshas wrong strength/agility requirementsFixItemRequirementsPlugInhas correct requirements but only applies as runtime patchSolution Summary:
FixItemRequirementsPlugIn.cs.FixItemRequirementsPlugIn2to handle existing game configurations that were created after the original fix but before the base data correction.Technical Details:
The issue was in the base requirement values used during weapon initialization. These values are processed through a calculation formula that multiplies them by drop level, so having incorrect base values led to inflated final requirements.
Files Modified:
src/Persistence/Initialization/VersionSeasonSix/Items/Weapons.cs- Fixed initial bow requirementssrc/Persistence/Initialization/Updates/FixItemRequirementsPlugIn2.cs- New migration plugin with current datesrc/Persistence/Initialization/Updates/UpdateVersion.cs- Added new update versionImpact:
Fixes #644.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.