SpectralSequences v1.1: switched to Complexes #3921
+399
−419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SpectralSequences package to use Complexes. I noticed that #3807 and previous attempts had several bugs (e.g. conversion from truncate to naiveTruncation and the indices in the y-filtration were wrong), so I started from scratch.
truncate(Complex,ZZ)
tonaiveTruncation(Complex,ZZ)
.min/max
behave differently for Complex and ChainComplex and are used in three different places which could cause inconsistencies if there were hidden assumptions in the past. This is worth a review.Future things to do: