Skip to content

SpectralSequences v1.1: switched to Complexes #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: development
Choose a base branch
from

Conversation

mahrud
Copy link
Member

@mahrud mahrud commented Jul 8, 2025

This PR updates the SpectralSequences package to use Complexes. I noticed that #3807 and previous attempts had several bugs (e.g. conversion from truncate to naiveTruncation and the indices in the y-filtration were wrong), so I started from scratch.

  • updated helpers in SpectralSequences
    • this commit also deletes various ChainComplex methods that were implemented in SpectralSequences but are now implemented by Complexes
    • it also renames truncate(Complex,ZZ) to naiveTruncation(Complex,ZZ).
  • updated methods in SpectralSequences
  • fixed the filteredComplex(List) constructor
  • fixed the filteredComplex(Complex) constructor
  • updated docs in SpectralSequences
  • updated tests in SpectralSequences
  • fixed an indexing bug in SpectralSequences
    • min/max behave differently for Complex and ChainComplex and are used in three different places which could cause inconsistencies if there were hidden assumptions in the past. This is worth a review.

Future things to do:

  • split the file in an auxiliary directory
  • trim the documentation; several nodes are 95% duplicates, and some nodes are so huge that the whole documentation is about 12MB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant