Skip to content

no remap targets with remap=false #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2022
Merged

no remap targets with remap=false #81

merged 2 commits into from
Sep 13, 2022

Conversation

zomb-676
Copy link
Contributor

@zomb-676 zomb-676 commented Sep 5, 2022

No description provided.

@XiaoPangxie732 XiaoPangxie732 self-assigned this Sep 5, 2022
@XiaoPangxie732 XiaoPangxie732 added this to the 3.3 milestone Sep 5, 2022
@XiaoPangxie732 XiaoPangxie732 linked an issue Sep 5, 2022 that may be closed by this pull request
[Enhancement] Support mixin classes #77
Open
zomb-676 and others added 2 commits September 8, 2022 02:41
@zomb-676 @XiaoPangxie732
no remap targets with remap=false
ba61066
@XiaoPangxie732
(WIP) #77
ebee57c 
Fix mixin class gets removed when remap=false
TODO:
- Remap refmap
@XiaoPangxie732 XiaoPangxie732 self-requested a review September 12, 2022 19:40
XiaoPangxie732
XiaoPangxie732 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@XiaoPangxie732 XiaoPangxie732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@XiaoPangxie732 XiaoPangxie732 merged commit 870dcb5 into MaxPixelStudios:master Sep 13, 2022
@XiaoPangxie732 XiaoPangxie732 removed a link to an issue Sep 13, 2022
[Enhancement] Support mixin classes #77
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoPangxie732 XiaoPangxie732 XiaoPangxie732 approved these changes

Assignees

@XiaoPangxie732 XiaoPangxie732

Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@zomb-676 @XiaoPangxie732