MML4 draft #537
Open
MML4 draft #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nabil YOUSSEF <[email protected]>
Signed-off-by: Nabil YOUSSEF <[email protected]>
Signed-off-by: Nabil YOUSSEF <[email protected]>
Signed-off-by: Nabil YOUSSEF <[email protected]>
Signed-off-by: Pierre-Elie Personnaz <[email protected]>
Signed-off-by: Pierre-Elie Personnaz <[email protected]>
Signed-off-by: Pierre-Elie Personnaz <[email protected]>
Signed-off-by: Pierre-Elie Personnaz <[email protected]>
Signed-off-by: Pierre-Elie Personnaz <[email protected]>
hadrienp-met
requested changes
Jun 27, 2025
There was a problem hiding this comment.
Merci ! Deux remarques principales :
- Il y a peut être un truc qui m'échappe mais je comprends pas pourquoi on a besoin de définir des paramètres
_constant? Tel qu'ils sont utilisés, ce sont des variables d'initalisation mais on n'en a pas besoin por les paramètres - Il reste des composants à adapter comme l'ACC, je vais faire la liste
- Idéalement il faudrait qu'on ai un modèle direct aussi de Metroscopia
- Et il faudra adapter tous les tests
Bref pas mal de boulot qui doit mobiliser toute l'équipe !
Comment on lines
+15
to
+16
| parameter Real tau_constant = 15; | ||
| parameter Real eta_is_constant = 0.8; |
There was a problem hiding this comment.
Pourquoi on a ces paramètres ? Ils ne sont pas utilisés ensuite
| @@ -12,9 +12,9 @@ model GasTurbine | |||
| import MetroscopeModelingLibrary.Utilities.Units; | |||
| import MetroscopeModelingLibrary.Utilities.Units.Inputs; | |||
|
|
|||
| parameter Units.Yield eta_is_constant = 0.8; | |||
There was a problem hiding this comment.
Idem pourquoi ce paramètre ?
Suggested change
| parameter Units.Yield eta_is_constant = 0.8; |
| Inputs.InputFrictionCoefficient Kfr_hot(start=0); | ||
| Inputs.InputArea S; | ||
| parameter Units.Area S = 15000; | ||
| parameter Units.MassFraction x_steam_out = 1; // Steam mass fraction at water outlet |
There was a problem hiding this comment.
Il faut garder les surfaces en paramètres modifiable, on l'utilise dans certains cas
| Inputs.InputHeatExchangeCoefficient Kth; | ||
| Inputs.InputFrictionCoefficient Kfr_cold; | ||
| Inputs.InputFrictionCoefficient Kfr_hot; | ||
| parameter Units.Area S = 3000; |
There was a problem hiding this comment.
On modifie parfois les surfaces pour faire des hypotheses
| @@ -26,6 +26,13 @@ model GasTurbine | |||
| Units.Percentage eta_is_decrease(min = 0, max=100) "percentage decrease of eta_is"; | |||
|
|
|||
| Power.Connectors.Outlet C_W_shaft annotation (Placement(transformation(extent={{90,90},{110,110}}), iconTransformation(extent={{90,90},{110,110}}))); | |||
| Utilities.Interfaces.GenericReal eta_is(start=eta_is_constant) annotation (Placement(transformation( | |||
There was a problem hiding this comment.
On a un besoin d'initialiser les eta is ? ça me semble pas utile
| @@ -5,7 +5,7 @@ partial model ControlValve | |||
| import MetroscopeModelingLibrary.Utilities.Units.Inputs; | |||
| import MetroscopeModelingLibrary.Utilities.Constants; | |||
|
|
|||
| Inputs.InputCv Cv_max(start=1e4) "Maximum CV"; | |||
| parameter Units.Cv Cv_max_constant = 1e4 "Maximum CV"; | |||
There was a problem hiding this comment.
Idem pourquoi le constant ?
| parameter Boolean faulty = false; | ||
| Units.Percentage fouling; // Fouling coefficient | ||
|
|
||
| parameter Units.Height delta_z_constant = 10; |
|
|
||
| parameter Boolean faulty = false; | ||
| Units.Percentage closed_valve; // Valve not fully opened | ||
|
|
||
| parameter Real Cv_constant = 1e4; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
PR adding connectors to most CCGT and NPP components
A lot of parameters have also been given a default value inside the component so there is no need to attribute it in the model
Type of change
package.mo)Will it break anything in previous models ?
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.