Skip to content

Conversation

Brian-Clement
Copy link
Collaborator

@Brian-Clement Brian-Clement commented Dec 17, 2020

Description

Re-enables the old Hatter theme and sets it as the site default. Introduces the Switch Page Theme module to leave the green "O'MidCamp" theme enabled on/2020* pages only.

To test

@Brian-Clement Brian-Clement mentioned this pull request Dec 17, 2020
@backlineint
Copy link
Member

backlineint commented Dec 17, 2020

Short term, I think this is fine to get the site back to our default colors. But going back to the original hatter theme will lose out on some changes that were made to the hatter base theme (that the O'midcamp theme depended on.) Templates for the caption field and some webform related theming look to be the biggest changes.

We could port those back to the original hatter theme, but my preference would be to create a new evergreen theme that uses hatter_base and an updated version of hatter_v2 style guide that is reverted back to our default theme.

Merging what we have now will give me a little more time to work on that, and when that is ready the only real config change we'll need to make would be changing the default theme setting.

@backlineint
Copy link
Member

Created a WIP PR for the Hatter changes here: MidCamp/hatter-v2#19

@Brian-Clement
Copy link
Collaborator Author

We could port those back to the original hatter theme, but my preference would be to create a new evergreen theme that uses hatter_base and and updated version of hatter_v2 style guide that is reverted back to our default theme.

This sounds ideal @backlineint. I feel the approach in this PR should only be considered a stop-gap measure. I will merge this for now and be ready to move to the new theme once it is ready.

@Brian-Clement Brian-Clement merged commit 65e43ad into master Dec 18, 2020
@Brian-Clement Brian-Clement deleted the feature/theme-switching branch December 18, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants