Rework HashUtils to support Alder32 and CRC32 and be faster #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not gonna require it for approval, but a chart/comparison of this in Mavenizer would be helpful to visualize the gains. |
LexManos
reviewed
Sep 22, 2025
LexManos
reviewed
Sep 22, 2025
LexManos
reviewed
Sep 22, 2025
| HashFunction func = functions[x]; | ||
| MessageDigest digest = digests[x]; | ||
| ret[x] = func.pad(new BigInteger(1, digest.digest()).toString(16)); | ||
| ret[x] = functions[x].hash(file); |
There was a problem hiding this comment.
This was actually explicitly written this way because the disc IO is the main concern when hashing files. Doing it this way makes things a lot slower because the entire file needs to be read for each hash function, instead of once.
Jonathing
requested changes
Sep 22, 2025
There was a problem hiding this comment.
As discussed on Discord, please re-work this PR using static getter methods instead of adding more public API.
https://discord.com/channels/1129059589325852724/1129095235889270844/1419795694625099866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this a while back and forgot about it, whoops!
Needs testing and review before merging.