Skip to content

Update Minestom to 1.21.5 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FluxCapacitor2
Copy link

Hi! I decided to take a stab at updating VRI to 1.21.5. This PR is still a work-in-progress, but I wanted to share it early. If anyone wants to contribute, feel free to open a PR at BlueDragonMC/VanillaReimplementation. Everything compiles, but much more manual testing is needed before I can confirm that everything is working properly.

Major changes:

  • NamespaceID -> Key
  • Changed window's package name
  • Minestom's 1.21.2 recipe changes
  • Various Minestom refactoring: FloatRange -> Range.Float, ChunkUtils -> CoordConversion, Entity.Pose -> EntityPose, Player.Hand -> PlayerHand, PacketUtils -> PacketSendingUtils, etc.

Here are all the issues I've found so far.

  • TNT explosions don't work
  • Stonecutter recipes appear, but clicking on one sometimes fills in the result slot with the result of a different recipe
  • Water flow doesn't work
  • Lighting a nether portal doesn't work
  • Ore smelting recipes aren't grouped in the recipe book
  • When a falling block lands on a chest, it drops a chest instead of the entity's block type

Here are the features I've tested. If an item is checked here, then it's working or the bugs I've found have been added to the list above.

  • block-update-system
    • Random ticks
  • blocks
    • Chest
    • Bed
    • Cake
    • Concrete powder
    • Ender chest
    • Trapped chest
    • End portal
    • Gravity blocks (sand, gravel)
    • Jukebox
    • TNT
    • Block loot from loot tables
    • Copper oxidization
    • Crafting menus (furnace, crafting table, stonecutter, smoker, etc)
  • commands
  • crafting
    • Crafting table and survival inventory crafting
    • Recipe book (crafting table, furnace, smoker, blast furnace)
    • Stonecutter
    • Smithing table
    • Furnace
    • Blast furnace
    • Smoker
  • datapack-loading (loads 1.21.5 data successfully on startup)
  • datapack-tests (all pass)
  • entities
    • Falling blocks
    • Primed TNT
  • entity-meta (nothing to test?)
  • fluid-simulation
  • instance-meta (unsure how to test)
  • item-placeables (water and lava buckets)
  • items (flint and steel)
  • world-generation

Fixes #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Due to recent update of Minestom how to update Recipe module
1 participant