Skip to content

fix: 1204 bounding boxes are missing for many feeds with good stopstxt files #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Jun 17, 2025

Summary:

add support for the rebuild_missing_bounding_boxes task, enable the detection and processing of GTFS datasets missing bounding box information.

image

Expected behavior:

image

Testing tips:

Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Jun 17, 2025 that may be closed by this pull request
@qcdyx qcdyx marked this pull request as ready for review June 18, 2025 15:09
@emmambd
Copy link
Collaborator

emmambd commented Jun 18, 2025

To clarify, this doesn't solve #1204 but it does help us detect these problems when they happen in the logs?

@qcdyx
Copy link
Contributor Author

qcdyx commented Jun 19, 2025

To clarify, this doesn't solve #1204 but it does help us detect these problems when they happen in the logs?

This solves #1024, I'll put int the logic of checking the existence of stops.txt after #1259 is resolved.

@qcdyx qcdyx requested a review from davidgamez June 19, 2025 16:43
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qcdyx qcdyx merged commit 453f002 into main Jun 23, 2025
9 checks passed
@qcdyx qcdyx deleted the 1204-bounding-boxes-are-missing-for-many-feeds-with-good-stopstxt-files branch June 23, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounding boxes are missing for many feeds with good stops.txt files
3 participants