-
Notifications
You must be signed in to change notification settings - Fork 7
Progressr and future_lapply #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
==========================================
- Coverage 96.71% 96.40% -0.31%
==========================================
Files 7 7
Lines 669 668 -1
==========================================
- Hits 647 644 -3
- Misses 22 24 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, both extensions are a great
A minor drawback is the additional dependencies, but these packages are fairly safe and should not cause any problems in the future.
looking forward version 1.0 on CRAN 🎉🎉🎉
I am not yet 100% convinced of future_lapply/progressr. So I am tending to release 0.9 without this PR, then take sometime to gain more experience with it, and then eventually go for 1.0.0. |
Will keep it open, but not merge yet
This PR brings to changes that were very high up in the candidates for release 1.0.0:
future.apply::future_lapply()
: To use {kernelshap()} in parallel mode, the user now can simply runplan(...)
. No other changes are necessary. Compared to the old approach (foreach
), packages like {ranger} etc seem to be correctly moved into the corresponding environments. This did not work before because the need for these packages are masked bystats::predict()
.@pbiecek
@dswatson
Let me know if you see some other important stuff for version 1.