Skip to content

[fix]pydantic to dict when build prompt #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

[fix]pydantic to dict when build prompt #967

merged 2 commits into from
Jul 15, 2025

Conversation

SangChengC
Copy link
Contributor

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @SangChengC, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a data format incompatibility issue within the prompt building process. It ensures that message objects, likely received as Pydantic models, are correctly transformed into a dictionary format before being used by Jinja templates, thereby fixing potential rendering or parsing errors in the prompt generation system.

Highlights

  • Data Conversion for Prompt Building: The pull request introduces a change to convert request.messages from Pydantic objects into a list of dictionaries. This is achieved by iterating through the messages and calling model_dump(by_alias=True, exclude_none=True) on each.
  • Jinja Templating Compatibility Fix: An inline comment clarifies that this conversion is necessary because Jinja templating, when used with tokenizer_config.json to assemble templates, cannot properly recognize Pydantic objects. Converting them to dictionaries resolves this compatibility issue.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses an issue where the Jinja templating engine was unable to correctly process Pydantic objects when building prompts. The solution involves converting the Pydantic message objects to dictionaries before passing them to the templating engine. A comment was added to explain the reason for the conversion.

Comment on lines +13 to +14
# pydantic格式转成dict, 否则,当根据tokenizer_config.json拼template时,Jinja判断无法识别
messages = [m.model_dump(by_alias=True, exclude_none=True) for m in request.messages]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's good to see a comment explaining the reason for the conversion to a dictionary. However, consider adding a more specific comment indicating which part of the tokenizer_config.json is affected by this conversion. This will help future developers understand the context better.

Suggested change
# pydantic格式转成dict, 否则,当根据tokenizer_config.json拼template时,Jinja判断无法识别
messages = [m.model_dump(by_alias=True, exclude_none=True) for m in request.messages]
# pydantic格式转成dict, 否则,当根据tokenizer_config.json拼template时,Jinja判断无法识别, 尤其是tools参数

@SangChengC SangChengC changed the title Fix OpenAI image [fix]pydantic to dict when build prompt Jul 10, 2025
@hiworldwzj hiworldwzj merged commit 8ed97c7 into main Jul 15, 2025
1 check passed
@hiworldwzj hiworldwzj deleted the fix_openai_image branch July 15, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants